search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 393 forks source link

Fix Collection return type in Query class template #1989

Open tsybenko opened 5 months ago

tsybenko commented 5 months ago

Fixes https://github.com/propelorm/Propel2/issues/1975

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8d22484) 89.28% compared to head (4ffc406) 89.28%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1989 +/- ## ========================================= Coverage 89.28% 89.28% Complexity 8058 8058 ========================================= Files 232 232 Lines 24534 24534 ========================================= Hits 21905 21905 Misses 2629 2629 ``` | [Flag](https://app.codecov.io/gh/propelorm/Propel2/pull/1989/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | Coverage Δ | | |---|---|---| | [5-max](https://app.codecov.io/gh/propelorm/Propel2/pull/1989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `89.28% <ø> (ø)` | | | [7.4](https://app.codecov.io/gh/propelorm/Propel2/pull/1989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `89.28% <ø> (ø)` | | | [agnostic](https://app.codecov.io/gh/propelorm/Propel2/pull/1989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `67.44% <ø> (ø)` | | | [mysql](https://app.codecov.io/gh/propelorm/Propel2/pull/1989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `69.83% <ø> (ø)` | | | [pgsql](https://app.codecov.io/gh/propelorm/Propel2/pull/1989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `69.87% <ø> (ø)` | | | [sqlite](https://app.codecov.io/gh/propelorm/Propel2/pull/1989/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `67.81% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PhilinTv commented 5 months ago

Thanks @tsybenko for the PR!

Unfortunately the issue is not in the FQCN, the a wrong recognition of psalm class intersection (&), which triggers Phpstorm to recognise Collection as a magic function name 🙈

With FQCN, IDEs don't recognize this row complete, so we can use that to temporary fix it for psalm notation without losing information.