search

propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

Support Symfony v7 components #1990

Closed gharlan closed 8 months ago

PhilinTv commented 9 months ago

A good idea! Any PRs we can start with? :)

pableu commented 9 months ago

What are your thoughts on dropping support for unsupported Symfony versions?

https://symfony.com/releases:

But even if we drop unsupported versions, I think it'll be very challenging to have support for Symfony 5, 6 and 7 at the same time. Symfony 7 introduced numerous strict types, I doubt it's possible to implement those changes in this library in a way that works with Symfony 6 and 7 at the same time.

Just as an example: The properties of \Propel\Runtime\Validator\Constraints\Date would need to be typed for Symfony 7 compatibility, but they can not be typed for Symfony 6 compatibility.

Since this is still in beta, should we just go for it and require Symfony 7 components and PHP 8.2?

Leonardo-Atalla commented 9 months ago

@PhilinTv I opened a PR to allow Symfony 7 here: https://github.com/propelorm/Propel2/pull/1992

PhilinTv commented 8 months ago

Resolved in the last release 😉