propelorm / Propel2

Propel2 is an open-source high-performance Object-Relational Mapping (ORM) for modern PHP
http://propelorm.org/
MIT License
1.26k stars 399 forks source link

use parent:: instead of ModelCritera:: #2016

Open rizwanjiwan opened 2 months ago

rizwanjiwan commented 2 months ago

As recommended in php docs http://php.adamharvey.name/manual/en/keyword.parent.php

2009

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.97%. Comparing base (3417fea) to head (2951a74). Report is 4 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation: There is a different number of reports uploaded between BASE (3417fea) and HEAD (2951a74). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (3417fea) | HEAD (2951a74) | |------|------|------| |7.4|4|3| |5-max|4|3| |agnostic|1|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2016 +/- ## ============================================= - Coverage 89.25% 73.97% -15.28% Complexity 8065 8065 ============================================= Files 232 232 Lines 24550 24550 ============================================= - Hits 21911 18161 -3750 - Misses 2639 6389 +3750 ``` | [Flag](https://app.codecov.io/gh/propelorm/Propel2/pull/2016/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | Coverage Δ | | |---|---|---| | [5-max](https://app.codecov.io/gh/propelorm/Propel2/pull/2016/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `73.97% <ø> (-15.28%)` | :arrow_down: | | [7.4](https://app.codecov.io/gh/propelorm/Propel2/pull/2016/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `73.97% <ø> (-15.28%)` | :arrow_down: | | [agnostic](https://app.codecov.io/gh/propelorm/Propel2/pull/2016/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `?` | | | [mysql](https://app.codecov.io/gh/propelorm/Propel2/pull/2016/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `69.79% <ø> (-0.02%)` | :arrow_down: | | [pgsql](https://app.codecov.io/gh/propelorm/Propel2/pull/2016/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `69.84% <ø> (ø)` | | | [sqlite](https://app.codecov.io/gh/propelorm/Propel2/pull/2016/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm) | `67.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=propelorm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.