search

propelorm / PropelBundle

PropelBundle for Symfony.
http://propelorm.org/Propel/documentation/#working-with-symfony2
180 stars 156 forks source link

YAML files parsed in production #448

Closed gharlan closed 7 years ago

gharlan commented 7 years ago

In my app blackfire.io gives me this recommendation:

screenshot 2017-02-24 18 00 53

The yaml parsings are caused by this line: https://github.com/propelorm/PropelBundle/blob/3.0/Request/ParamConverter/PropelParamConverter.php#L107

This part was added in #245 (ping @havvg).

I'm not sure, how we could "fix" it.

marcj commented 7 years ago

AFAIK router->getRouteCollection always hits the raw actual config files since it's not cached (only its build routes urls). There's afaik no built-in solution to get a list of all Route instances.

gharlan commented 7 years ago

https://github.com/symfony/symfony/issues/11171

So maybe we should move the propel_converter into defaults?