search

propelorm / PropelBundle

PropelBundle for Symfony.
http://propelorm.org/Propel/documentation/#working-with-symfony2
180 stars 156 forks source link

Fix deprecation issues raised by PropelTypeGuesser #454

Closed tjveldhuizen closed 7 years ago

tjveldhuizen commented 7 years ago

I've replaced the type names with the FQCN's as suggested in https://github.com/symfony/symfony/blob/2.8/UPGRADE-2.8.md#form, but didn't use the class constants, since Symfony 2.8 also targets PHP versions before 5.5.

I've also flipped the choices-array as suggested in https://github.com/symfony/symfony/blob/2.8/UPGRADE-2.7.md#form when the column type is ENUM

tjveldhuizen commented 7 years ago

After creating this PR, I found a comment by @marcj in #441 telling the 1.5 branch is not maintained anymore. I think this should be made clear in some way, to protect people from doing useless work. When you're using 1.5 at the moment, https://github.com/propelorm/PropelBundle/blob/1.5/README.markdown is the first thing you'll look at, in my opinion. This states it's one of the major supported branches