search

propelorm / PropelBundle

PropelBundle for Symfony.
http://propelorm.org/Propel/documentation/#working-with-symfony2
180 stars 156 forks source link

[1.6] Wrong allowedTypes #466

Closed nibsirahsieu closed 6 years ago

nibsirahsieu commented 6 years ago

https://github.com/propelorm/PropelBundle/blob/e10bb77cb823448ce648ca2c1127b5421f3c8071/Form/Type/ModelType.php#L245

it should be \ModelCriteria

nibsirahsieu commented 6 years ago

ping @jaugustin

jaugustin commented 6 years ago

@nibsirahsieu good catch it's fixed ;) but we should add tests for this class

nibsirahsieu commented 6 years ago

👍 . One more, it's seem you forgot to backport the PropelExtension.php class

jaugustin commented 6 years ago

@nibsirahsieu the current code seems ok. I didn't test it with a real use case.

Do we have any issue with the current 1.6 ?

nibsirahsieu commented 6 years ago

i haven't tried it yet, i'm still using my own fork. But after reading the code, nothing wrong actually. Both of them are valid.