search

propelorm / PropelBundle

PropelBundle for Symfony.
http://propelorm.org/Propel/documentation/#working-with-symfony2
180 stars 156 forks source link

Symfony 4.0 updates #483

Closed kingchills closed 6 years ago

kingchills commented 6 years ago

Added support for Symfony 4.0. Updated unit tests to remove deprecated functions, and match current object serialization strings for YamlDumper

eugenekurasov commented 6 years ago

When this PR will be merge? I see all tests is passed

eugenekurasov commented 6 years ago

Hi @cristianoc72 can you merge this PR?

cristianoc72 commented 6 years ago

@eugenekurasov sorry, I can't: I haven't push rights on this repo

marcj commented 6 years ago

Will this remove Symfony 2.8-3.x support? If so, we need to merge this in a new 4.x branch.

kingchills commented 6 years ago

It looks like @cristianoc72 confirmed working in 3.4, and I have confirmed this will break in 2.8. Shall I update the readme to reflect working versions? Looks like it would make sense to create it's own branch until I can figure out backwards compatibility

marcj commented 6 years ago

Yes, please update the readme accordingly. I changed the target branch to 4.0

eugenekurasov commented 6 years ago

@kingchills can you update readme?

eugenekurasov commented 6 years ago

@kingchills thank you Ping @marcj

marcj commented 6 years ago

Thanks!