search

propelorm / sfPropelORMPlugin

symfony 1.x plugin for Propel.
http://www.propelorm.org/
Other
109 stars 95 forks source link

Update sfFormPropel.class.php #222

Closed tofuwarrior closed 10 years ago

tofuwarrior commented 10 years ago

set label was using empty_name not empty_label option and so empty_label option inneffective when using ->embedRelation Edited line 675.

rozwell commented 10 years ago

It looks like empty_name shouldn't be there, it just overrides empty_label, but according to docs, it should be just empty_label:

  • empty_label: The label of the empty form. Defaults to 'new' + the relation name.

@tofuwarrior would you like to get rid of empty_name? Basically by removing lines: 554, 569, 675 and renaming remaining empty_name to empty_label.

rozwell commented 10 years ago

Let's just hope nobody runs into backward compatibility issues, fixed in: #223

tofuwarrior commented 10 years ago

Thanks for update and fix details. Guess people can easily track down issues now it is documented if there are backwards compatibility problems.

Paul

On 22 Jul 2014, at 12:33, rozwell notifications@github.com wrote:

It looks like empty_name shouldn't be there, it just overrides empty_label, but according to docs, it should be empty_label:

empty_label: The label of the empty form. Defaults to 'new' + the relation name. @tofuwarrior would you like to get rid of empty_name? Basically by removing lines: 554, 569, 675 and renaming remaining empty_name to empty_label.

— Reply to this email directly or view it on GitHub.