search

proper-testing / proper

PropEr: a QuickCheck-inspired property-based testing tool for Erlang
http://proper-testing.github.io
GNU General Public License v3.0
879 stars 168 forks source link

Fix more_commands/2 #228

Closed x4lldux closed 4 years ago

x4lldux commented 4 years ago

Original more_commands/2 wasn't working as expected because the adjusting of size with resize/2 wasn't propagating to "deeper" types.

Fixes #192.

With these changes I get:

....................................................................................................
OK: Passed 100 test(s).

Length of Cmds
minimum: 0
average: 8.93
maximum: 36
....................................................................................................
OK: Passed 100 test(s).

Length of Cmds
minimum: 0
average: 96.33
maximum: 398
kostis commented 4 years ago

Thanks @x4lldux for your PR!

As you can see, based on your change, I've done a (IMO) stylistically better change to proper_statem (in the commit which is referenced above) and also added two related tests in this branch.

You can either change your commit to have the changes of this one and then I can merge this PR -- so that you get the PropEr credit -- or alternatively I can close this PR and push the changes of my branch.

Let me know which you prefer. In either case, your name (or github account ID if you do not wish to reveal your name) can be added to this file.