search

proper-testing / proper

PropEr: a QuickCheck-inspired property-based testing tool for Erlang
http://proper-testing.github.io
GNU General Public License v3.0
879 stars 168 forks source link

readme: fix correct git clone URI #302

Closed kikofernandez closed 1 year ago

kikofernandez commented 1 year ago

This commit fixes the URI for the call git clone. It used to be:

git clone git://github.com/proper-testing/proper.git

but it has been replaced by:

git clone https://github.com/proper-testing/proper.git

I got timeouts when calling git clone git://github.com/proper-testing/proper.git.

pablocostass commented 1 year ago

Good catch! It should have either been either the HTTPS URI (your fix) or the SSH URI (git@github.com:proper-testing/proper.git), but it seems both options got mixed up resulting in an improper URI

kostis commented 1 year ago

Thanks for your interest in PropEr and thanks for noticing this. (Also, season's greetings to both of you!)

As mentioned in #303, which extends testing with the recently released Erlang/OTP 25.2, since there would be changes in the README file anyway, I folded the fix there (using the SSH URI). Hope this is OK. I will close this PR.