proper-testing / proper

PropEr: a QuickCheck-inspired property-based testing tool for Erlang
http://proper-testing.github.io
GNU General Public License v3.0
880 stars 168 forks source link

Move cleanup logic into Makefile #309

Closed kostis closed 1 year ago

kostis commented 1 year ago

PR #308 brought up the issue that the clean command of rebar3 had a Unix-based script as a post_hook that could not be run on Windows. Rather that adopting #308 and run the risk of leaving out some OSes, move all cleanup logic, including calling cleanup scripts, to the Makefile instead. This should avoid rebar3 clean crashing on Windows.

While at it, move the rebar3 clean call from the distclean to the clean target of Makefile, which seems more standard.

Closes #308

codecov-commenter commented 1 year ago

Codecov Report

Merging #309 (d6a7353) into master (3de5f72) will increase coverage by 0.10%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #309      +/-   ##
==========================================
+ Coverage   85.35%   85.46%   +0.10%     
==========================================
  Files          14       14              
  Lines        4590     4590              
==========================================
+ Hits         3918     3923       +5     
+ Misses        672      667       -5     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.