PHP warnings and notices when saving viewings

[tomslominski]

I'm seeing a few warnings and notices when saving viewings. None are critical or prevent the viewings from being saved. I have the viewing feedback plugin installed, which I think is part of the problem for some of these. This is on PHP 7.4.1.

When searching for an applicant to add to the viewing:

[27-Mar-2020 09:31:19 UTC] PHP Warning:  Parameter 2 to PH_AJAX::search_contacts_where() expected to be a reference, value given in /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php on line 288
[27-Mar-2020 09:31:19 UTC] PHP Stack trace:
[27-Mar-2020 09:31:19 UTC] PHP   1. {main}() /Users/tom/Sites/site.local/app/public/wp-admin/admin-ajax.php:0
[27-Mar-2020 09:31:19 UTC] PHP   2. do_action($tag = *uninitialized*, ...$arg = variadic()) /Users/tom/Sites/site.local/app/public/wp-admin/admin-ajax.php:175
[27-Mar-2020 09:31:19 UTC] PHP   3. WP_Hook->do_action($args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:478
[27-Mar-2020 09:31:19 UTC] PHP   4. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:312
[27-Mar-2020 09:31:19 UTC] PHP   5. PH_AJAX->search_contacts(*uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:288
[27-Mar-2020 09:31:19 UTC] PHP   6. WP_Query->__construct($query = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-content/plugins/propertyhive/includes/class-ph-ajax.php:1089
[27-Mar-2020 09:31:19 UTC] PHP   7. WP_Query->query($query = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-query.php:3522
[27-Mar-2020 09:31:19 UTC] PHP   8. WP_Query->get_posts() /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-query.php:3413
[27-Mar-2020 09:31:19 UTC] PHP   9. apply_filters_ref_array($tag = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-query.php:2541
[27-Mar-2020 09:31:19 UTC] PHP  10. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:249
[27-Mar-2020 09:31:19 UTC] PHP Notice:  like_escape is <strong>deprecated</strong> since version 4.0.0! Use wpdb::esc_like() instead. in /Users/tom/Sites/site.local/app/public/wp-includes/functions.php on line 4648
[27-Mar-2020 09:31:19 UTC] PHP Stack trace:
[27-Mar-2020 09:31:19 UTC] PHP   1. {main}() /Users/tom/Sites/site.local/app/public/wp-admin/admin-ajax.php:0
[27-Mar-2020 09:31:19 UTC] PHP   2. do_action($tag = *uninitialized*, ...$arg = variadic()) /Users/tom/Sites/site.local/app/public/wp-admin/admin-ajax.php:175
[27-Mar-2020 09:31:19 UTC] PHP   3. WP_Hook->do_action($args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:478
[27-Mar-2020 09:31:19 UTC] PHP   4. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:312
[27-Mar-2020 09:31:19 UTC] PHP   5. PH_AJAX->search_contacts(*uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:288
[27-Mar-2020 09:31:19 UTC] PHP   6. WP_Query->__construct($query = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-content/plugins/propertyhive/includes/class-ph-ajax.php:1089
[27-Mar-2020 09:31:19 UTC] PHP   7. WP_Query->query($query = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-query.php:3522
[27-Mar-2020 09:31:19 UTC] PHP   8. WP_Query->get_posts() /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-query.php:3413
[27-Mar-2020 09:31:19 UTC] PHP   9. apply_filters_ref_array($tag = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-query.php:2541
[27-Mar-2020 09:31:19 UTC] PHP  10. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:249
[27-Mar-2020 09:31:19 UTC] PHP  11. PH_AJAX->search_contacts_where($where = *uninitialized*, $wp_query = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:288
[27-Mar-2020 09:31:19 UTC] PHP  12. like_escape($text = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-content/plugins/propertyhive/includes/class-ph-ajax.php:1130
[27-Mar-2020 09:31:19 UTC] PHP  13. _deprecated_function($function = *uninitialized*, $version = *uninitialized*, $replacement = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/deprecated.php:3438
[27-Mar-2020 09:31:19 UTC] PHP  14. trigger_error(*uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/functions.php:4648

When saving any new viewing:

[27-Mar-2020 09:32:35 UTC] PHP Notice:  Undefined index: _feedback in /Users/tom/Sites/site.local/app/public/wp-content/plugins/propertyhive/includes/admin/post-types/meta-boxes/class-ph-meta-box-viewing-details.php on line 60
[27-Mar-2020 09:32:35 UTC] PHP Stack trace:
[27-Mar-2020 09:32:35 UTC] PHP   1. {main}() /Users/tom/Sites/site.local/app/public/wp-admin/post.php:0
[27-Mar-2020 09:32:35 UTC] PHP   2. edit_post($post_data = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-admin/post.php:219
[27-Mar-2020 09:32:35 UTC] PHP   3. wp_update_post($postarr = *uninitialized*, $wp_error = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-admin/includes/post.php:407
[27-Mar-2020 09:32:35 UTC] PHP   4. wp_insert_post($postarr = *uninitialized*, $wp_error = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/post.php:4197
[27-Mar-2020 09:32:35 UTC] PHP   5. do_action($tag = *uninitialized*, ...$arg = variadic(*uninitialized*, *uninitialized*, *uninitialized*)) /Users/tom/Sites/site.local/app/public/wp-includes/post.php:4120
[27-Mar-2020 09:32:35 UTC] PHP   6. WP_Hook->do_action($args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:478
[27-Mar-2020 09:32:35 UTC] PHP   7. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:312
[27-Mar-2020 09:32:35 UTC] PHP   8. PH_Admin_Meta_Boxes->save_meta_boxes($post_id = *uninitialized*, $post = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:290
[27-Mar-2020 09:32:35 UTC] PHP   9. do_action($tag = *uninitialized*, ...$arg = variadic(*uninitialized*, *uninitialized*)) /Users/tom/Sites/site.local/app/public/wp-content/plugins/propertyhive/includes/admin/post-types/class-ph-admin-meta-boxes.php:1769
[27-Mar-2020 09:32:35 UTC] PHP  10. WP_Hook->do_action($args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:478
[27-Mar-2020 09:32:35 UTC] PHP  11. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:312
[27-Mar-2020 09:32:35 UTC] PHP  12. PH_Meta_Box_Viewing_Details::save($post_id = *uninitialized*, $post = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:288

When saving viewing with newly created applicant:

[27-Mar-2020 09:34:37 UTC] PHP Notice:  Undefined variable: applicant_contact_id in /Users/tom/Sites/site.local/app/public/wp-content/plugins/propertyhive/includes/admin/post-types/meta-boxes/class-ph-meta-box-viewing-applicant.php on line 389
[27-Mar-2020 09:34:37 UTC] PHP Stack trace:
[27-Mar-2020 09:34:37 UTC] PHP   1. {main}() /Users/tom/Sites/site.local/app/public/wp-admin/post.php:0
[27-Mar-2020 09:34:37 UTC] PHP   2. edit_post($post_data = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-admin/post.php:219
[27-Mar-2020 09:34:37 UTC] PHP   3. wp_update_post($postarr = *uninitialized*, $wp_error = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-admin/includes/post.php:407
[27-Mar-2020 09:34:37 UTC] PHP   4. wp_insert_post($postarr = *uninitialized*, $wp_error = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/post.php:4197
[27-Mar-2020 09:34:37 UTC] PHP   5. do_action($tag = *uninitialized*, ...$arg = variadic(*uninitialized*, *uninitialized*, *uninitialized*)) /Users/tom/Sites/site.local/app/public/wp-includes/post.php:4120
[27-Mar-2020 09:34:37 UTC] PHP   6. WP_Hook->do_action($args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:478
[27-Mar-2020 09:34:37 UTC] PHP   7. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:312
[27-Mar-2020 09:34:37 UTC] PHP   8. PH_Admin_Meta_Boxes->save_meta_boxes($post_id = *uninitialized*, $post = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:290
[27-Mar-2020 09:34:37 UTC] PHP   9. do_action($tag = *uninitialized*, ...$arg = variadic(*uninitialized*, *uninitialized*)) /Users/tom/Sites/site.local/app/public/wp-content/plugins/propertyhive/includes/admin/post-types/class-ph-admin-meta-boxes.php:1769
[27-Mar-2020 09:34:37 UTC] PHP  10. WP_Hook->do_action($args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/plugin.php:478
[27-Mar-2020 09:34:37 UTC] PHP  11. WP_Hook->apply_filters($value = *uninitialized*, $args = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:312
[27-Mar-2020 09:34:37 UTC] PHP  12. PH_Meta_Box_Viewing_Applicant::save($post_id = *uninitialized*, $post = *uninitialized*) /Users/tom/Sites/site.local/app/public/wp-includes/class-wp-hook.php:288

[propertyhive]

Thanks for reporting these. Much appreciated. The latter 2 should be easy fixes as they're just undefined variables so will get these done for the next release. The first errors mentioned might need a little more tweaking, but again, will try to get all of these resolved for the next release.

Thanks, Steve

[propertyhive]

I'll leave this issue open for now and close once the release is out.

[propertyhive]

These warnings/errors all sorted in the latest release of Property Hive (v1.4.57).

Steve