search

propertyhive / WP-Property-Hive

The complete estate agency software plugin for WordPress
Other
27 stars 27 forks source link

Problem adding media floorplans and EPC #122

Closed Spring279 closed 4 years ago

Spring279 commented 4 years ago

Problem adding media floorplans and EPC. Please can this be resolved asap.

espc-jcampbell commented 4 years ago

Having a similar issue, only seems to be happening after the 1.4.65 update (having also updated WordPress to 5.5). Will try rolling the plugin back to see if it works.

EDIT: Have tried 1.4.64 and .63 and the issue persists, must be WP 5.5 that's causing it?

EDIT 2: It is indeed WP 5.5 - something to do with the removal of their jQuery Migrate 1.4.1 script. I installed a plugin as a quick fix if anyone wants to do the same . It also returns the following errors on the edit property page:

jQuery.fn.load() is deprecated jQuery.fn.live() is deprecated jQuery.fn.live() is deprecated jQuery.fn.live() is deprecated jQuery.fn.live() is deprecated jQuery.fn.live() is deprecated

tomnightingale-adtrak commented 4 years ago

Hi,

jQuery 1.12.4. has been included in Wordpress since 4.6 - and live() is not supported beyond 1.9 As mentioned above, it looks like it's the removal of jQuery migrate.

Searching the PropertyHive plugin, there's two calls to the live function in the following files:

..\plugins\propertyhive\includes\admin\post-types\meta-boxes\class-ph-meta-box-property-photos.php:251 ..\plugins\propertyhive\includes\admin\ph-meta-box-functions.php:141 ..\plugins\propertyhive\includes\admin\class-ph-admin-settings.php:589 ..\plugins\propertyhive\includes\admin\post-types\meta-boxes\class-ph-meta-box-property-epcs.php:221 ..\plugins\propertyhive\includes\admin\post-types\meta-boxes\class-ph-meta-box-property-floorplans.php:286

Consider replacing this with jQuery's .on() function.

EDIT: Found a few more instances of live. Updated list, added line numbers.

propertyhive commented 4 years ago

Thanks for reporting, and apologies for the inconvenience. Just to confirm a new release was put out this morning at around 8am that rectifies this.

Steve