674 pinned notes

[propertyhive]

https://trello.com/c/UXiSNkGD

[propertyhive]

Looking great :) Only comments are:

• Should be able to pin an existing note. I'm thinking maybe a small blue link like the 'Delete' link
• Check what happens when there is no 'Pin Note' checkbox and you try and save a note. I'm thinking in the scenario where a third party plugin has added it's own note grid. The 'Pin Note' tickbox wouldn't exist but it would call the same JS (I think). If it wouldn't use the same JS don't worry about this.
• Obviously needs rolling out to all the other post types/note grids. I'm thinking this might be a good opportunity to move the 'Add Note' form into a view if they're all the same. If they are it can go into /includes/admin/views/
• Do we think pinned notes should appear at the top, but also in the normal chronological order where they would've appeared previously? I'm thinking yes but open to suggestions/discussion on this.
• As for appearance I think we should just make pinned notes a different colour (i.e #F5E57E). Maybe add an icon of some sort?
• Need to think about unpinning?
• When you pin a note does the grid get redrawn dynamically to put it at the top right away?
• Remember to run all labels etc through __() or _e() so they can be translated (I.e. the 'Pin Note' checkbox label)

Looking perfect so far!

[egar01n]

Great notes, thanks. The ability to pin existing, and unpin and style is all still to come and I'll make sure to implement some of the other bits you've mentioned which I hadn't thought of.

• For whether the pinned note should also appear chronologically, I had thought about it and my take was that they shouldn't still appear in the list. Mostly because that's conventional with other pinned notes systems I've seen. But equally keeping them there would be simple and I think it would save more confusion than it would cause, so happy to do that instead if you'd like.
• At the moment when you pin (or create) a new note, it gets put at the top of the grid regardless. So the task is to either put an unpinned one in under the pinned ones, or to just redraw the grid. I'll investigate.