propertyhive / WP-Property-Hive

The complete estate agency software plugin for WordPress
Other
26 stars 27 forks source link

EPC and brochure image preview and edit link bug #175

Open davidball4444 opened 3 years ago

davidball4444 commented 3 years ago

From what I can tell I've found 2 separate issues:

  1. If you have your wordpress default image sizes with either the height of width set to zero, no image preview displays on the edit property admin page -> media. This is quite a common setup as wordpress users sometimes want their images to keep proportional or not be cropped.
  2. The image preview on the same page has the default attachment hover classes for editing or deleting the image, but for the EPC and brochure, these links take you back directly to the main property page.

I've tried to amend the code in the property hive meta-boxes folder: class-ph-box-property-epcs.php, but as I don't fully understand wordpress and its setup, I thought It'd be better to leave it to the experts!

propertyhive commented 3 years ago

@davidball4444 Thanks for reporting the issues. Have added to the roadmap (https://trello.com/c/yNETlpvr) to be looked at today. We should have a release going out in the next day or two so expect this to be part of that.

Thanks, Steve

egar01n commented 3 years ago

Hi David, For your second point, the fix for the Edit icons on EPCs and brochures is straight-forward and has been written. Once it's reviewed and released, we'll let you know. I did some testing on your first point and with the height and widths in my Wordpress settings set to 0, the thumbnails were still appearing in the Property Photos section when I uploaded new images. Could you give me a little more detail of what exactly your settings are when you're experiencing the problem and, if possible, what images are being created in your uploads folder when you upload an image? Many thanks, Eoin