search

propertyhive / WP-Property-Hive

The complete estate agency software plugin for WordPress
Other
27 stars 27 forks source link

The "meta-boxes.js" file contains some hardcoded strings #241

Open DAnn2012 opened 1 month ago

DAnn2012 commented 1 month ago

The "meta-boxes.js" file contains some hardcoded strings, such as 'Deleting...', 'Adding...', 'Updating...', 'Saving...' and others.

It would be better if these strings were translatable, so that these corresponding strings found in other files can also be translated:

https://github.com/propertyhive/WP-Property-Hive/blob/master/includes/admin/post-types/meta-boxes/class-ph-meta-box-contact-actions.php#L358

https://github.com/propertyhive/WP-Property-Hive/blob/master/includes/admin/post-types/meta-boxes/class-ph-meta-box-contact-actions.php#L782

https://github.com/propertyhive/WP-Property-Hive/blob/master/includes/admin/post-types/meta-boxes/class-ph-meta-box-property-actions.php#L846

Thanks.

propertyhive commented 1 month ago

@DAnn2012 Just a quick one to let you know this has been received and it will be reviewed over the coming days and merged accordingly. Really appreciate your input.