search

prophet-kn / dnd_spells_book

Access the app at:
https://prophet-kn.github.io/dnd_spells_book/
Other
3 stars 1 forks source link

PC-24: Add top menu #59

Closed CuriousCactus closed 4 years ago

CuriousCactus commented 4 years ago

Routing added. Sticky top menu that hides on downward scroll and shows on upward scroll added.

prophet-kn commented 4 years ago

So many SCSS changes, once I merge linting PR you will have a nightmare fixing the merge conflict. :o Left comments in code. I haven't run the code yet, just looked at the diff.

prophet-kn commented 4 years ago

Right, so having a look at this on local, I didn't exactly want to redesign the menu... I meant more like, top left says "Prophet's Companion" and top right you have a burger SVG. Upon clicking that SVG a menu would slide out (or whatever animation, as long as it's quick) and then a redesigned menu pops up, just a 1 column list of items, also like 50-60px height, basic affordance etc, with an svg to close the burger.

Also, what are these? headroom headroom--unfixed headroom-disable-animation and when I scroll it goes insane and changes a lot causing unnecessary computations. These seem irrelevant completely, sticky nav can just be a position: sticky; top: 0;. And no inline styling like this with this random class <div class="headroom-wrapper" style="height: 46px;"> please, unless it is EXTREMELY impossible to have that height otherwise, also should be 50px either way. :s

prophet-kn commented 4 years ago

Since you've mentioned you might have no time on adjusting this PR, I made a new one https://github.com/prophet-kn/dnd_spells_book/pull/60 heavily inspired by what you've done here. Thanks! :)