search

proportions / proportions-js

Organic, Mechanical and Musical Proportions for JavaScript
MIT License
4 stars 0 forks source link

Precalculate #2

Open Undistraction opened 6 years ago

Undistraction commented 6 years ago

It would be better to precalculate all values - none of the scales change at runtime and you are forcing a dependency on Ramda. Much better to do the calculation and hardcode it for all values.

WebMechanic commented 2 years ago

this is an old issue but I also couldn't agree more with @Undistraction. I came back here 'cos I stumbled about this repo's URL in one of my stylesheet's comments ... and saw this. I appreciate the idea and effort put into collecting these values, @christianhg and I have manually copied some values for use in my stylesheets but this "package" seriously over-delivers.

This is probably one of the most unneccesary dependencies I've encountered for ages that turns this simple, static List Of Values object into massive code bloatware for no other reason as to brag with a built system and make it an ES module? 'cmon Especially if all calculations are trivial enough to be done with the native Math object anyway and the same amount of code ... and their guesstimated values are already present in the code comments anyway.