search

proposal-signals / signal-polyfill

Implementation tracking the current state of https://github.com/tc39/proposal-signals
Apache License 2.0
185 stars 13 forks source link

Turn off minify for release bundle #21

Closed ds300 closed 2 months ago

ds300 commented 3 months ago

I found it quite difficult to debug and patch the signal-polyfill package while working on this PR because this package is shipped to npm as a minified bundle. Since this is a not-for-production prototype and debugging/understanding it is one of the main purposes of it right now, maybe it makes sense to switch off minification?

Before:

image

After:

image
NullVoxPopuli commented 2 months ago

Thank you!

Yes, minification in an app concern, not a library one. (Or used traditionally via script tags or esm.sh imports)

We can use export conditions to have both, but that's a level of polish i don't think we're ready for.