search

proposal-signals / signal-utils

MIT License
69 stars 6 forks source link

fix(deps): mark `signal-polyfill` as a peer dependency #53

Closed nicojs closed 2 months ago

nicojs commented 2 months ago

The signal-utils package provides a set of utilities for working with signals. It should not depend on the signal-polyfill directly, as it should allow users to choose their version of the polyfill.

NullVoxPopuli commented 2 months ago

makes sense to me -- can you also update the README in the installation instructions to mention installing the polyfill?

nicojs commented 2 months ago

I could, but peer dependencies should be installed automatically by the package manager.

NullVoxPopuli commented 2 months ago

I could, but peer dependencies should be installed automatically by the package manager.

only if enabled and for certain package managers, afaik -- many folks aren't even aware of this behavior :sweat_smile:

NullVoxPopuli commented 2 months ago

thank you!!