search

proptest-rs / proptest

Hypothesis-like property testing for Rust
Apache License 2.0
1.69k stars 158 forks source link

Remove byteorder dependency #360

Closed psychon closed 1 year ago

psychon commented 1 year ago

The Rust standard library includes some byteorder-like helper functions for a while already. This commit replaces the use of byteorder with these helper functions.

I have no particular reason for this except for trying to remove a dependency. byteorder is not a "bad" dependency, but it still seemed unnecessary to me to do what is being done here.

Feel free to tell me that this is not worth it. :-)

psychon commented 1 year ago

to check the commit that added the dependency to see if there's any additional context.

git log --reverse -p -S byteorder says this was added in commit 4ba7873374f56f67e9c83f67a0135df4401a1bb1. That commit adds the dependency, but makes no use of it?!

Commit e9fe26ac7d568379e37cc55b49ec619a7052e59c adds it as extern crate, but still makes no use of it.

The first real use appears in commit 6953a233a123f90f28df537ac3090db6605538b4 in a function convert_to_new_format(). It is used to convert [u32; 4] to [u8; 16] in little endian.

Dunno...

matthew-russo commented 1 year ago

Ha that was quick -- thanks for checking.