search

proptest-rs / proptest

Hypothesis-like property testing for Rust
Apache License 2.0
1.63k stars 152 forks source link

Depend on regex-syntax 0.7 or 0.8 #381

Closed sjackman closed 8 months ago

sjackman commented 8 months ago

Depend on regex-syntax 0.7 or 0.8.

matthew-russo commented 8 months ago

If you get a chance, can you rebase and update your branch so we can get CI running? I tried to do it but i can't push to your branch

matthew-russo commented 8 months ago

and fixes #379

matthew-russo commented 8 months ago

this actually got addressed by our recent merge of dependabot:

https://github.com/proptest-rs/proptest/pull/386

sjackman commented 8 months ago

this actually got addressed by our recent merge of dependabot

Yeah! Awesome that Dependabot is now running on this repo!

If you get a chance, can you rebase and update your branch so we can get CI running? I tried to do it but i can't push to your branch

This PR is different than Dependabot's PR #386 in that this PR permits either regex-syntax version 0.7 or 0.8, whereas Dependabot's PR permits only version 0.8. I've rebased this PR onto origin/master. Would you please reopen this PR and merge it?

matthew-russo commented 8 months ago

Is there a use case for still requiring 0.7? I expected a dependency on 0.8 to suffice.

sjackman commented 8 months ago

Is there a use case for still requiring 0.7? I expected a dependency on 0.8 to suffice.

A more permissive dependency allows a project to use either regex-syntax version 0.7 or 0.8, so that if that project hasn't yet updated their direct dependency on regex-syntax from version 0.7 to 0.8, they don't need to install two versions of regex-syntax, one for the direct dependency of their project, and one for the indirect dependency through proptest.

Dependabot supports updating version = ">=0.7, <0.9" to version = ">=0.7, <0.10" in a Dependabot PR.