propublica / politwoops_sunlight

Politwoops web front end
Other
44 stars 30 forks source link

Screenshot worker sometimes gets error page to upgrade browser #26

Closed nickom closed 6 years ago

nickom commented 10 years ago

For example, this deleted tweet linking to the LA Times returns this error: 473940281151078400-0

dvogel commented 10 years ago

The production version of politwoops uses an ancient version of phantomjs (1.6, current is 1.9). I'll try to upgrade it soon.

nickom commented 10 years ago

:+1:

dvogel commented 10 years ago

Even the newest version of phantomjs won't work with the LA Times. Their website requires a feature still not implemented in the WebKit version included in phantomjs 1.9. Here is the relevant code from their site:

    notmobileCalccheck: function () {
        if (this.isMobile()) {
            return true;
        }
        var a = document.createElement("div");
        a.style.cssText = "width:-webkit-calc(10px);width:calc(10px)";
        return !!a.style.length;
    },

This is in the same "waiting for v2.0" bucket as #27

nickom commented 10 years ago

Gotcha, thanks for checking it out. Are you still going to upgrade to the latest version of phantomjs?

dvogel commented 10 years ago

As we speak :)

nickom commented 10 years ago

:)