search

propublica / upton

A batteries-included framework for easy web-scraping. Just add CSS! (Or do more.)
MIT License
1.62k stars 113 forks source link

fix broken/incomplete test #12

Closed kgrz closed 11 years ago

kgrz commented 11 years ago

These tests pertain to the downloading and caching part. These tests in their current form are broken. These will be re-added in the next couple of commits

kgrz commented 11 years ago

These tests are broken on my machine. I will re-add them anyway after extraction of the downloading part (~ 1 day)

jeremybmerrill commented 11 years ago

I included the failing tests as a sort of to-do list of tests to write; they were skipped in minitest, but I don't know what the idiomatic thing to do is with RSpec in this scenario.

kgrz commented 11 years ago

you could do:

it "should do something" do
  pending
end

or just:

it "should do something"
jeremybmerrill commented 11 years ago

Yes, @dannguyen included that on his PR #14. I'm just gonna merge his (once I get a chance to look through resolve_url), since y'all both suggest the same thing.

kgrz commented 11 years ago

I saw that PR but forgot to close this :/