search

proseLA / authorizenet_cim

CIM Module for authorizenet for zencart
3 stars 2 forks source link

Make getCustomerCards() return the same type of object in all places #50

Closed scottcwilson closed 3 years ago

scottcwilson commented 3 years ago

Sample log from version 2.2.3

demo.log

proseLA commented 3 years ago

the demo log does not make sense to me. let me look at the history a bit.

scottcwilson commented 3 years ago

Let's close this for now. You had fixed the issue I was seeing in a more recent version of the software, so these changes don't really make sense - but you may want to consider the change in admin/includes/classes/observers/class.cim_admin_observer.php.

proseLA commented 3 years ago

yeah. in the future please open an issue as opposed to doing the work on a PR. the more i am now looking at this PR, the more problems i am seeing. there were different elements to the array in _cim getCreditCards than in the fields of the object of resultQuery... and your !empty in the template file was set the wrong way.

there is a lot of lines of code here, and at some point i hope to be able to refactor it and make it cleaner, but there are very few people using it; and my affiliate link for auth.net nets me $7.50/month. barely enough to get extra cheese on my whopper!

i'm going to do a small refactor as i agree with you on the original point; i have the same method name in different classes which returned different object types. and i do not like that at all. despite it working fine.

best.

best.

scottcwilson commented 3 years ago

Very good. Thanks for the review!