search

prost-planner / prost

probabilistic planning system for tasks encoded in RDDL
MIT License
41 stars 17 forks source link

Convert hooks from mercurial to git #107

Open thomaskeller79 opened 4 years ago

thomaskeller79 commented 4 years ago

The hooks in the script folder are for a mercurial repo. In this issue, we'd like to convert them to git.

geisserf commented 4 years ago

I had this link in my history from some years ago when setting up clang-format for my git repositories, unfortunately the tutorial I had seems to be offline now.

This repository seems to be often recommended, but from a quick glance it automatically formats code rather than giving the user a commit error message that the code is not correctly formatted.

speckdavid commented 4 years ago

Since we are planning to include automated style checking with github actions, which I hope to integrate soon, I wonder if we really need a hook script. The only advantage I see is that we'll never have commits with incorrectly formatted files. However, since we plan to include the requirement that all github actions must be successful in our workflow, I guess and hope we'll never have an incorrectly formatted file in the master branch or main repo in the future.

thomaskeller79 commented 4 years ago

I wouldn't look into this too deeply as they are currently working on the same issue in the Fast Downward sprint. If we need is another question, though, and I don't mind it if the result is that these files are removed from the repo and we set up things on the server-side instead.

geisserf commented 4 years ago

I think it can still be useful since it removes unnecessary commits and also shortens the amount of time it takes when you forgot to format a file.