Sort explanation services (updated)

protegeproject / protege

Protege Desktop

http://protege.stanford.edu

Other

1.01k stars 231 forks source link

Sort explanation services (updated) #1214

Closed gouttegd closed 4 months ago

gouttegd commented 4 months ago

This PR builds upon @stefborg’s #1059 to add the fixes recommended by @ykazakov :

do not create a new ExplanationPreferences object when applying the changes in the preference dialog;
make sure the “move up”/“move down” buttons are initially disabled when the dialog is first shown and no explanation service is selected;
add a ”Change priority” label next to those buttons.

(I hope you don’t mind, @stefborg. I’m keen to release 5.6.4 before the end of the week.)

stefborg commented 4 months ago

Thank you, @gouttegd for the fixes, they look good to me! I didn't have any time today to do it myself. And thanks to @ykazakov for the thorough testing!