search

protegeproject / rdf-library

OWLAPI RDF library
9 stars 10 forks source link

Fix GH-6 migrate to rdf4j #7

Open abrokenjester opened 5 years ago

abrokenjester commented 5 years ago

This PR addresses issue #6

Changes:

The owl api version bump was necessary because the older version used sesame internally.

This PR is not ready for merge as-is: in particular the class AnonymousResourceHandler needs scrutiny. This class used a lot of OWL API functionality that has significantly changed between version 4 and 5, and I couldn't immediately make sense of it. Feedback most welcome. My fork should be editable to the maintainers so if you wish to push fixes to my repo/branch, by all means do.

matthewhorridge commented 5 years ago

Hi @jeenbroekstra thanks a lot for the contribution! Much appreciated.

We are kind of nervous about updating Protege to OWL API 5 right now as it is backwards incompatible with 4 and thus updating Protege with 5 has the potential to break a lot of plugins. I think we'll look at doing this for Protege 6 (we have a big Protege 5.5 release coming soon).

abrokenjester commented 5 years ago

That makes sense. Unfortunately we can't switch to rdf4j without this upgrade. Only option I see is that we convince the owl API project to release a 4.3 release that updates to java 8 and rdf4j but doesn't change its own APIs. Not sure if that's realistic though.

abrokenjester commented 5 years ago

@matthewhorridge you want to keep this PR open for future reference, or do you prefer to close it for now? Either way once you've started migration to OWLAPI 5 feel free to give me a nudge, happy to assist with sesame to rdf4j migration any way I can.

matthewhorridge commented 5 years ago

@jeenbroekstra yes, I'll keep it open for future reference. Thanks so much for the kind offer of assistance - I really appreciate it!