proteinevolution / Toolkit

The MPI Bioinformatics Toolkit
https://toolkit.tuebingen.mpg.de
Apache License 2.0
63 stars 14 forks source link

Microsoft Internet Explorer and Edge multiple issues #204

Closed vikramalva closed 6 years ago

vikramalva commented 6 years ago

I get emails from Edge/Explorer users every once in a while, complaining that certain features do not work. Our Toolkit is not rendered properly on these browsers and I don't think we should try to make the Toolkit work on them. We should perhaps display a warning message when users try to use the Toolkit on these browsers.

felixgabler commented 6 years ago

I added a warning to the view on the print-handling branch. It might be a bit much since one cannot hide this warning yet. Should I add the possibility to hide it?

Furthermore I think we should actually at least investigate what parts of the site don't work. If it's not a lot of work, we could perhaps support Edge aswell.

vikramalva commented 6 years ago

I think we should offer a possibility to hide the warning. Some pages and buttons are not rendered properly as well as some feature like downloading files do not work.

zy4 commented 6 years ago

Why not fix it for these browsers? A warning to switch browsers does not look good.

vikramalva commented 6 years ago

We could eventually make the Toolkit work properly on these browsers. There are a bunch of issues to be dealt with. @felixgabler may be you could take a look.

vikramalva commented 6 years ago

The message is not displayed on my IE browser.

felixgabler commented 6 years ago

I cannot find many problems on my Edge browser. Only one button which should be fixed now. Will look into the downloading thing next, but I would be glad if you could point me to some more issues with IE/Edge. If we could at least get Edge to work properly, that would be great.

vikramalva commented 6 years ago

The following image shows some of the issues I notice on my IE browser: ie_issues

The left side, including the logo, is squashed. 'Upload file' has a background color.

vikramalva commented 6 years ago

For the download issue see these examples: https://toolkit.tuebingen.mpg.de/#/jobs/1971402 'Download PDB file'

https://toolkit.tuebingen.mpg.de/#/jobs/4335613 'Download MSA'

It is an HTML tag-related issue.

vikramalva commented 6 years ago

By the way, may be we should not show the warning message at all and just fix these issues one at a time. I am going to use and test the Toolkit on IE over the next days. In fixing these issues, we should make sure that we don't break the Toolkit on Safari, Chrome, and Firefox.

felixgabler commented 6 years ago

Did you find more issues? I want to look at this some more later

zy4 commented 6 years ago

Felix, do you know how to install VMWare Player on your machine? This is quite useful to have a Windows instance running.

felixgabler commented 6 years ago

I know how to, but then I would also need windows licences and everything. I can just test from home

Seung-Zin Nam notifications@github.com schrieb am Sa., 23. Dez. 2017, 13:17:

Felix, do you know how to install VMWare Player on your machine? This is quite useful to have a Windows instance running.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/zy4/Toolkit/issues/204#issuecomment-353723181, or mute the thread https://github.com/notifications/unsubscribe-auth/AaEXSDoI0a8cpnDMe0XvJasTj6d6BXrKks5tDO9FgaJpZM4RCJx7 .

zy4 commented 6 years ago

I think for our purposes it might be even free.

vikramalva commented 6 years ago

I haven't found anything other obvious issues, but I have not gone through all the pages thoroughly.

felixgabler commented 6 years ago

Most issues should be fixed now. Please check the logo and the downloads especially.

vikramalva commented 6 years ago

Logo looks fine now and downloading works on some of the pages I tested. I, however, found some other new issues. I will try to post some of them tomorrow.

vikramalva commented 6 years ago

Some issues:

1) The ''FASTA Alignment'' view is broken on IE; this is used by many tools (e.g., all alignment tools, HHpred, HHblits)

ie1

vikramalva commented 6 years ago
  1. Switching to Full-screen mode and then back to normal mode breaks the Results view of almost all tools.

ie2

vikramalva commented 6 years ago
  1. Even after a job runs through, it is shown to be in the Queued state and I'm not taken to the Results page. The side pane shows the correct status color though.

ie3

felixgabler commented 6 years ago

The only thing I couldn't fix yet is issue 3. I cannot run jobs from home and don't have internet explorer at the mpi. I will have to push this back a bit.

felixgabler commented 6 years ago

Also this issue only exists on internet explorer and not on edge.

vikramalva commented 6 years ago

239

The second issue is not resolved on IE on my laptop.

felixgabler commented 6 years ago

Can you try again? I had to resort to implementing a hacky solution because IE does behave in a very weird way. I hope that it will go away when we rewrite it. We have to keep an eye on that

vikramalva commented 6 years ago

Still broken.

untitled

felixgabler commented 6 years ago

Can you tell me your user-agent?

vikramalva commented 6 years ago

Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko

felixgabler commented 6 years ago

Ok, it should detect it correctly. I increased the timeout even more. Can you check one last time.

vikramalva notifications@github.com schrieb am Mo., 1. Jan. 2018, 18:40:

Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zy4/Toolkit/issues/204#issuecomment-354665649, or mute the thread https://github.com/notifications/unsubscribe-auth/AaEXSL-NKPCtBP8dLEMkDhyJybZOy_ooks5tGRiogaJpZM4RCJx7 .

vikramalva commented 6 years ago

Does not work on my browser. May be someone else should also check this on a different Windows machine.

zy4 commented 6 years ago

@vikramalva try to raise the timeout even more and report us back whether this is the wrong approach at all

zy4 commented 6 years ago

We could also try something with https://developer.mozilla.org/de/docs/Web/API/window/requestAnimationFrame

felixgabler commented 6 years ago

Where would you use it?

Seung-Zin Nam notifications@github.com schrieb am Mi., 3. Jan. 2018, 11:01:

We could also try something with https://developer.mozilla.org/de/docs/Web/API/window/requestAnimationFrame

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zy4/Toolkit/issues/204#issuecomment-354974490, or mute the thread https://github.com/notifications/unsubscribe-auth/AaEXSPyShvTZs1mtZVQ16ROEYTy-C3s9ks5tG0_pgaJpZM4RCJx7 .

zy4 commented 6 years ago

instead of setTimeout

felixgabler commented 6 years ago

This shouldn't be an issue. The problem is that I can't figure out why the classes are removed.

Seung-Zin Nam notifications@github.com schrieb am Mi., 3. Jan. 2018, 11:15:

instead of setTimeout

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zy4/Toolkit/issues/204#issuecomment-354977105, or mute the thread https://github.com/notifications/unsubscribe-auth/AaEXSB4IGIbZaePJ9Ds3x5b6uUs5YT4uks5tG1M3gaJpZM4RCJx7 .

zy4 commented 6 years ago

I think this is a similar problem to what we had with the tooltips (there also classes were removed after the page loaded). Chances are that it works in IE when you reset before #161

felixgabler commented 6 years ago

I used a different approach this time. I would guess that it works now. @vikramalva can you check again?

vikramalva commented 6 years ago

@felixgabler works now!

vikramalva commented 6 years ago

I noticed another small issue on the Results page of HHpred, HHblit, PSI-BLAST; the toolbar is not aligned to the left as on other browsers.

untitled

vikramalva commented 6 years ago

On Chrome:

untitled1

felixgabler commented 6 years ago

Should be fixed now. @vikramalva please check