search

proteinevolution / Toolkit

The MPI Bioinformatics Toolkit
https://toolkit.tuebingen.mpg.de
Apache License 2.0
62 stars 14 forks source link

'Load Hits' is broken #393

Closed vikramalva closed 6 years ago

vikramalva commented 6 years ago

  1. Run HHpred with the following sequence:

    d2bykb1 a.22.1.3 (B:11-99) Chrac-14 {Fruit fly (Drosophila melanogaster) [TaxId: 7227]} PNAVIGRLIKEALPESASVSKEARAAIARAASVFAIFVTSSSTALAHKQNHKTITAKDILQTLTELDFESFVPSLTQDLEVYRKVVKEK

  2. Click on the last bar in the visualization map to get to Hit nr. 108. 'Load Hits' is displayed, but clicking on it results in a console error ReferenceError: getsHitsManually is not defined

This is possibly also the case for HMMER, HHblits, PSI-BLAST, and HHomp.

felixgabler commented 6 years ago

Exactly what I want to tackle in #347

vikramalva commented 6 years ago

Indeed the same issue. We should try to fix this before we merge Develop with Master.

felixgabler commented 6 years ago

This would be a quick fix but I wanted to refactor some more around this functionality. Will take some time on saturday for this. I don't have time throughout the week.

zy4 commented 6 years ago

Also the LoadingOverlay doesn't show up anymore

felixgabler commented 6 years ago

I removed the loadingoverlay from the loadhits function. As far as I remember, you were also in favour of it.

zy4 commented 6 years ago

No, as long as the loading takes that long, I think it is better to have it. I mostly found it annoying to have it on the result pages of the msa tools when it could be triggered by scrolling down when you are on the bottom.

felixgabler commented 6 years ago

In my opinion, it is fine to display only the "Loading hits.." message.

felixgabler commented 6 years ago

Should be fixed in #397