search

proteinevolution / Toolkit

The MPI Bioinformatics Toolkit
https://toolkit.tuebingen.mpg.de
Apache License 2.0
63 stars 14 forks source link

Help Button for HHpred Manual #632

Closed zy4 closed 6 years ago

zy4 commented 6 years ago

has no modal. Should be removed or a modal should be implemented.

zy4 commented 6 years ago

By the way isn't it the sole purpose of HTMP to forward to modeller? Can't we just forward directly without the intermediate result page of HTMP?

That would also solve #629 because we can do more behind the scenes.

vikramalva commented 6 years ago

Yes, that's the sole purpose. These jobs, however, frequently need several minutes to complete and that's why it is necessary to have the intermediate page.

zy4 commented 6 years ago

Should all be handeled async in the background. In my opinion HTMP is not a tool and should be gone from the frontend.

vikramalva commented 6 years ago

Having this intermediate step allows users to do other things in parallel while waiting for the HTMP job to completely. If we would also handle it like forwarding, users would be bound to the parent page.

zy4 commented 6 years ago

No, I was talking about dispatching a modeller job right away but hiding the htmp part

vikramalva commented 6 years ago

That's not a good idea, as users should be provided with the option to refactor the alignment created by HTMP, before it is submitted to MODELLER.

zy4 commented 6 years ago

I doubt then that the issue we have with #629 was ever implemented in way which covers all possible cases. If the htmp result gets altered how can we guarantee that the changes are forwarded correctly? I think this needs a deeper refactoring.

vikramalva commented 6 years ago

Users can remove one or more template sequences from the created alignment and this does not require any refactoring of the code. This has been working very well all the time.

zy4 commented 6 years ago

Okay, but to close this issue. If we stick to HTMP as a submission tool, we should decide whether we do away with the help icon.

vikramalva commented 6 years ago

Let's do away with it.