Adopt dummy values for segmented sumexp that compile in latest cub

proteneer / timemachine

Differentiate all the things!

Other

138 stars 17 forks source link

Closed badisa closed 2 months ago

badisa commented 2 months ago

As apart of benchmarking https://github.com/proteneer/timemachine/pull/1312 on L4s, I found that I could not compile timemachine on the latest version of cub (shipped with Cuda 12.5.0). These were the changes necessary to compile the repo.

proteneer commented 2 months ago

Does this work with older versions of cub still? If not, should we also update the README to require Cuda 12.5+?

badisa commented 2 months ago

Does this work with older versions of cub still? If not, should we also update the README to require Cuda 12.5+?

Yup, the CI is still Cuda 11. Think we should look at upgrading Cuda, but this PR doesn't require it.