search

protesilaos / dired-preview

Automatically preview file at point in Emacs Dired.
GNU General Public License v3.0
55 stars 2 forks source link

Would you like a preview placeholder PR? #14

Closed xenodium closed 3 months ago

xenodium commented 3 months ago

Great package Prot. Thank you!

Unsure if this is working as expected or misconfigruation on my part, but I found my eyes were a little more rested (no sudden window layout changes) when using a placeholder preview for ignored files.

I have a tiny patch, but wanted to prefly the idea before sending a PR...

Without patch:

without-patch

With patch:

with-patch

Is this of interest?

protesilaos commented 3 months ago

Hello @xenodium!

Is this of interest?

Yes, this looks great. Maybe you can put it behind a defcustom in case someone prefers the old behaviour? But I am fine even without such an option.

xenodium commented 3 months ago

Yes, this looks great.

Great. Sent #15 PR.

Maybe you can put it behind a defcustom in case someone prefers the old behaviour?

Sounds good. Added dired-preview-ignored-show-ignored-placeholders.

protesilaos commented 3 months ago

I merged your PR. We can safely close this. Thank you!