protesilaos / dired-preview

Automatically preview file at point in Emacs Dired.
GNU General Public License v3.0
57 stars 2 forks source link

The operation only works on the n and p bindings and not arrow keys. #2

Open ronniedroid opened 1 year ago

ronniedroid commented 1 year ago

The preview only works when using the default n and p bindings (or j and k if using evil mode with evil-want-integration set to t) but not when using the arrow keys.

One other issue with this is, one gets a preview when using the n and p, then using the arrow keys to go to a different file and visit a file, the preview will not get closed.

Emacs version 28.2

ronniedroid commented 1 year ago

Sorry, I just noticed a closed issue also related to the arrow keys, but I will leave this one open as it mentions the preview not getting closed issue too.

protesilaos commented 1 year ago

Hello @ronniedroid! This should now be fixed. Though note that I am actively developing the package. Things remain in a state of flux, but I am hopeful that we are not far away from a stable core.

protesilaos commented 1 year ago

The first stable version of the package is available: https://protesilaos.com/codelog/2023-07-08-emacs-dired-preview-0-1-0/. This can be closed now.

Nekosis commented 1 year ago

Can this be reopened? I'm experiencing this same issue on my configuration. I have Evil mode enabled with evil-want-integration set to t as well, and only 'j' and 'k' are updating the preview buffer. If I try to use the arrow keys, the preview buffer does not update.

The configuration I'm experiencing this issue in is available here.

I'm using GNU Emacs 29.1.

Thanks for your amazing work!

Nekosis commented 1 year ago

EDIT to above: dired-preview branch was merged into main.

protesilaos commented 6 months ago

Hello @Nekosis! I missed this issue. Can you check if this works on your end? We have the dired-preview-trigger-commands, so we can add Evil's commands there, if needed.