protesilaos / dired-preview

Automatically preview file at point in Emacs Dired.
GNU General Public License v3.0
57 stars 2 forks source link

Maybe remove dired-preview-trigger-commands #7

Closed ghost closed 1 year ago

ghost commented 1 year ago

Hi prot, Maybe we should remove "dired-preview-trigger-commands". There are quite a lot of commands that cause movement in "dired", including "dired-unmark", "dired-unmark-backward", "mouse-set-point"... And there are also some commands, despite "this-command" not being able to recognize them, allow users to invoke "dired".

As a result, people cannot get the preview instantly in certain cases, such as when invoking "project-dired", for instance.

So, I don't think this function would bring any benefits, as the post-command-hook is sufficient for our purpose.