search

protesilaos / fontaine

Set Emacs font configurations using presets
https://protesilaos.com/emacs/fontaine
GNU General Public License v3.0
67 stars 1 forks source link

Non-existent `fontaine-latest-state-file` parent directory #10

Open krisbalintona opened 1 week ago

krisbalintona commented 1 week ago

Hi,

I have set fontaine-latest-state-file to a file with a parent directory that doesn't exist. Typically, in my experience, such packages will create the parent directories to write the file, if necessary.

Thus, I propose the addition of something like

(mkdir (file-name-directory fontaine-latest-state-file) t)

to fontaine-store-latest-preset.

protesilaos commented 5 days ago

From: Kristoffer Balintona @.***> Date: Fri, 18 Oct 2024 19:04:29 -0700

Hi,

Hello Kristoffer,

I have set fontaine-latest-state-file to a file with a parent directory that doesn't exist. Typically, in my experience, such packages will create the parent directories to write the file, if necessary.

Thus, I propose the addition of something like

(mkdir (file-name-directory fontaine-latest-state-file) t)

to fontaine-store-latest-preset.

Yes, this makes sense. Do you want to prepare the patch or shall I do it on my end?

-- Protesilaos Stavrou https://protesilaos.com

krisbalintona commented 5 days ago

On Sun, Oct 20 2024, Protesilaos Stavrou wrote:

[... 7 lines elided]

I have set fontaine-latest-state-file to a file with a parent directory that doesn't exist. Typically, in my experience, such packages will create the parent directories to write the file, if necessary.

Thus, I propose the addition of something like

(mkdir (file-name-directory fontaine-latest-state-file) t)

to fontaine-store-latest-preset.

Yes, this makes sense. Do you want to prepare the patch or shall I do it on my end?

-- Protesilaos Stavrou https://protesilaos.com

Either works, since it's a one-liner. I've attached what I had in mind.

-- Best, Kristoffer

protesilaos commented 4 days ago

From: Kristoffer Balintona @.***> Date: Sun, 20 Oct 2024 20:31:00 -0700

[... 22 lines elided]

Either works, since it's a one-liner. I've attached what I had in mind.

It seems the attachment got filtered out. Just tell which email to use and I will commit it from my side with you as the author. This way we have a record of your contribution in the Git history.

-- Protesilaos Stavrou https://protesilaos.com

krisbalintona commented 4 days ago

On Sun, Oct 20 2024, Protesilaos Stavrou wrote:

From: Kristoffer Balintona @.***> Date: Sun, 20 Oct 2024 20:31:00 -0700

[... 22 lines elided]

Either works, since it's a one-liner. I've attached what I had in mind.

It seems the attachment got filtered out. Just tell which email to use and I will commit it from my side with you as the author. This way we have a record of your contribution in the Git history.

-- Protesilaos Stavrou https://protesilaos.com

Ah, I assumed attaching attachments via email would work, but I guess they don't.

The email you can use is this one: @.*** Thank you!

-- Take care, Kristoffer