protesilaos / iosevka-comfy

Custom build of Iosevka with different style and metrics than the default.
Other
252 stars 7 forks source link

fontaine--set-face failing as signature of fontaine--set-face-properties has changed #13

Closed akartha closed 6 months ago

akartha commented 6 months ago

I kept getting a "Wrong type argument symbolp , 220" when changing fontaine presets.

Looking into it, I think I may have isolated it to the latest commit (fb528cd) where the definition of fontaine--set-face-attributes has changed to include 'slant' - (defun fontaine--set-face-attributes (face family &optional weight slant height frame)

but in the function fontaine--set-face, it is still being called without the 'slant' value -

(defun fontaine--set-face (preset face &optional frame)
  "Set font properties taken from PRESET to FACE in optional FRAME.
If FRAME is nil, apply the effect to all frames."
  (let ((properties (fontaine--get-preset-properties preset)))
    (fontaine--set-face-attributes
     face
     (or (plist-get properties (intern (format ":%s-family" face))) 'unspecified)
     (or (plist-get properties (intern (format ":%s-weight" face))) 'unspecified)
     (or (plist-get properties (intern (format ":%s-height" face))) 'unspecified)
     frame)))
akartha commented 6 months ago

Sorry - raised this against the wrong repo