protesilaos / iosevka-comfy

Custom build of Iosevka with different style and metrics than the default.
Other
264 stars 7 forks source link

Little issue with version 2.0 #17

Open DamienCassou opened 2 weeks ago

DamienCassou commented 2 weeks ago

I've just switched to version 2.0 and it doesn't look as good as it did in 1.4.0 :-).

Version 2.0

2024-08-30_21-28

Version 1.4.0

image

DamienCassou commented 2 weeks ago

I'm installing Iosevka-comfy from Nix and I'm responsible for the package. Here is the patch I wrote to update to v2: https://github.com/NixOS/nixpkgs/commit/f308200adfca54d9c30f387247e73cd5b0c0bafe?diff=split&w=0.

protesilaos commented 2 weeks ago

From: Damien Cassou @.***> Date: Fri, 30 Aug 2024 13:12:08 -0700

I've just switched to version 2.0 and it doesn't look as good as it did in 1.4.0 :-).

This is just the new trend in typography, haha!

I think you just need to restart Emacs for it to read the new files.

I'm installing Iosevka-comfy from Nix and I'm responsible for the package. Here is the patch I wrote to update to v2:

Thank you for this!

-- Protesilaos Stavrou https://protesilaos.com

DamienCassou commented 2 weeks ago

This is just the new trend in typography, haha!

not sure I will get used to it though :-D

I think you just need to restart Emacs for it to read the new files.

I unfortunately rebooted the computer before reporting the issue. The screenshot is after the reboot.

Thank you for this!

Thank you for this awesome font I'm using everywhere (desktop, web browser, Emacs...).

protesilaos commented 2 weeks ago

From: Damien Cassou @.***> Date: Sat, 31 Aug 2024 01:02:42 -0700

[... 5 lines elided]

I think you just need to restart Emacs for it to read the new files.

I unfortunately rebooted the computer before reporting the issue. The screenshot is after the reboot.

Oh, this is bad! Could it be some sandboxing issue on the Nix front? I am not sure how things work there... Put differently, does it work if you put the font files inside ~/.local/share/fonts? This assumes you are using fontconfig.

Thank you for this!

Thank you for this awesome font I'm using everywhere (desktop, web browser, Emacs...).

You are welcome! I enjoy doing this because I also use it everywhere.

-- Protesilaos Stavrou https://protesilaos.com

DamienCassou commented 1 week ago

Put differently, does it work if you put the font files inside ~/.local/share/fonts?

I'm using fontconfig and putting font files in ~/.local/share/fonts while removing them from Nix still shows the problem. Renaming these files from .ttf to .ttf.bak solves the problem immediately and renaming them back makes the problem reappear.

Here are the list of font files and each file size:

| 8565756 | .local/share/fonts/iosevka-comfy-motion-duo-normalbolditalic.ttf.bak | | 8232284 | .local/share/fonts/iosevka-comfy-motion-duo-normalboldupright.ttf.bak | | 8625536 | .local/share/fonts/iosevka-comfy-motion-duo-normalextrabolditalic.ttf.bak | | 8309840 | .local/share/fonts/iosevka-comfy-motion-duo-normalextraboldupright.ttf.bak | | 8553872 | .local/share/fonts/iosevka-comfy-motion-duo-normallightitalic.ttf.bak | | 8231888 | .local/share/fonts/iosevka-comfy-motion-duo-normallightupright.ttf.bak | | 8518220 | .local/share/fonts/iosevka-comfy-motion-duo-normalmediumitalic.ttf.bak | | 8231796 | .local/share/fonts/iosevka-comfy-motion-duo-normalmediumupright.ttf.bak | | 8454944 | .local/share/fonts/iosevka-comfy-motion-duo-normalregularitalic.ttf.bak | | 8158412 | .local/share/fonts/iosevka-comfy-motion-duo-normalregularupright.ttf.bak | | 8550572 | .local/share/fonts/iosevka-comfy-motion-duo-normalsemibolditalic.ttf.bak | | 8228684 | .local/share/fonts/iosevka-comfy-motion-duo-normalsemiboldupright.ttf.bak | | 8467664 | .local/share/fonts/iosevka-comfy-motion-duo-normalsemilightitalic.ttf.bak | | 8141324 | .local/share/fonts/iosevka-comfy-motion-duo-normalsemilightupright.ttf.bak | | 8489592 | .local/share/fonts/iosevka-comfy-motion-normalbolditalic.ttf.bak | | 8189004 | .local/share/fonts/iosevka-comfy-motion-normalboldupright.ttf.bak | | 8540260 | .local/share/fonts/iosevka-comfy-motion-normalextrabolditalic.ttf.bak | | 8256268 | .local/share/fonts/iosevka-comfy-motion-normalextraboldupright.ttf.bak | | 8416748 | .local/share/fonts/iosevka-comfy-motion-normallightitalic.ttf.bak | | 8180336 | .local/share/fonts/iosevka-comfy-motion-normallightupright.ttf.bak | | 8446148 | .local/share/fonts/iosevka-comfy-motion-normalmediumitalic.ttf.bak | | 8127928 | .local/share/fonts/iosevka-comfy-motion-normalmediumupright.ttf.bak | | 8393420 | .local/share/fonts/iosevka-comfy-motion-normalregularitalic.ttf.bak | | 8090076 | .local/share/fonts/iosevka-comfy-motion-normalregularupright.ttf.bak | | 8478480 | .local/share/fonts/iosevka-comfy-motion-normalsemibolditalic.ttf.bak | | 8161424 | .local/share/fonts/iosevka-comfy-motion-normalsemiboldupright.ttf.bak | | 8391616 | .local/share/fonts/iosevka-comfy-motion-normalsemilightitalic.ttf.bak | | 8091840 | .local/share/fonts/iosevka-comfy-motion-normalsemilightupright.ttf.bak | | 8494680 | .local/share/fonts/iosevka-comfy-normalbolditalic.ttf.bak | | 8125208 | .local/share/fonts/iosevka-comfy-normalboldupright.ttf.bak | | 8503020 | .local/share/fonts/iosevka-comfy-normalextrabolditalic.ttf.bak | | 8156164 | .local/share/fonts/iosevka-comfy-normalextraboldupright.ttf.bak | | 8408164 | .local/share/fonts/iosevka-comfy-normallightitalic.ttf.bak | | 8089520 | .local/share/fonts/iosevka-comfy-normallightupright.ttf.bak | | 8421640 | .local/share/fonts/iosevka-comfy-normalmediumitalic.ttf.bak | | 8051740 | .local/share/fonts/iosevka-comfy-normalmediumupright.ttf.bak | | 8378924 | .local/share/fonts/iosevka-comfy-normalregularitalic.ttf.bak | | 8034704 | .local/share/fonts/iosevka-comfy-normalregularupright.ttf.bak | | 8496568 | .local/share/fonts/iosevka-comfy-normalsemibolditalic.ttf.bak | | 8138544 | .local/share/fonts/iosevka-comfy-normalsemiboldupright.ttf.bak | | 8348188 | .local/share/fonts/iosevka-comfy-normalsemilightitalic.ttf.bak | | 8023620 | .local/share/fonts/iosevka-comfy-normalsemilightupright.ttf.bak |

Here are some changes between the 2 versions (some updates are smaller and others are larger): 2024-09-01_18-49

protesilaos commented 1 week ago

From: Damien Cassou @.***> Date: Sun, 1 Sep 2024 11:34:12 -0700

Put differently, does it work if you put the font files inside ~/.local/share/fonts?

I'm using fontconfig and putting font files in ~/.local/share/fonts while removing them from Nix still shows the problem. Renaming these files from .ttf to .ttf.bak solves the problem immediately and renaming them back makes the problem reappear.

This is bizarre... I have no good explanation for it. Can it be some caching issue? Otherwise, why would a slight change to the name produce the desired results.

[... 46 lines elided]

Here are some changes between the 2 versions (some updates are smaller and others are larger): 2024-09-01_18-49

I assume this is due to the changes made upstream. They probably reworked more of the "motion" characters than the "wide" ones.

Does the "wide+motion" variant have a larger increase than the regular "wide"?

-- Protesilaos Stavrou https://protesilaos.com