search

protesilaos / iosevka-comfy

Custom build of Iosevka with different style and metrics than the default.
Other
252 stars 7 forks source link

Ligatures not working properly on kitty #5

Closed calops closed 4 days ago

calops commented 1 year ago

I don't expect this to be necessarily the fault of this project, but I'm hoping for some guidance, as this issue doesn't appear on kitty with any other font that I've tested.

Here's how it looks on kitty version 0.28.1:
qcq1Hnn

And for reference, here's how it looks on wezterm: T1Li1bO

Any idea what might be the issue?

protesilaos commented 1 year ago

Hello @calops!

This is actually by choice. In the private-build-plans.toml you will find this:

export-glyph-names = false  # Set this to true for ligature support in Kitty (increased file size)

I once tried to build the files with export-glyph-names set to true, but the process took too long and was costly for my computer. The larger files would make working with this Git repository even more difficult.

calops commented 1 year ago

I see, thanks for the explanation, that makes sense!

I wonder, could it be possible to leverage github-actions to automatically build the big version of the files and publish them as releases? That way it won't hurt the repository's size, and it also won't burden your computer.

For the record, I installed the font from the nix packages available, which seem to simply pull them from this repo as-is.

protesilaos commented 1 year ago

From: Rémi Labeyrie @.***> Date: Wed, 17 May 2023 01:20:01 -0700

I see, thanks for the explanation, that makes sense!

You are welcome!

I wonder, could it be possible to leverage github-actions to automatically build the big version of the files and publish them as releases? That way it won't hurt the repository's size, and it also won't burden your computer.

I have never used github-actions, but assume it is possible. Though note that the GitHub repo is a mirror of the one on SourceHut. Whatever solution has to work everywhere and be easy to maintain.

For the record, I installed the font from the nix packages available, which seem to simply pull them from this repo as-is.

Good to know! I guess it just extracts the ttf files.

-- Protesilaos Stavrou https://protesilaos.com

calops commented 1 year ago

Here's what I came up with: https://github.com/calops/iosevka-comfy
With the relevant code here: https://github.com/calops/iosevka-comfy/blob/master/.github/workflows/release.yml

It automatically builds the fonts and uploads them as a new release whenever a release-* tag is pushed. You can see the result there: https://github.com/calops/iosevka-comfy/releases

I messed up the paths so the content of the archive is a bit messy for now, but you see the idea (and only one variant of the font is built this way, for now).

Doing it this way avoids committing the font files to the repository altogether, which seems like a more efficient use of git to me. For what it's worth, I intend to keep maintaining my repository if you don't like this approach. I will also probably write a nix flake to make things easier for me and other nix users.

protesilaos commented 1 year ago

I messed up the paths so the content of the archive is a bit messy for now, but you see the idea (and only one variant of the font is built this way, for now).

Looks promising!

Doing it this way avoids committing the font files to the repository altogether, which seems like a more efficient use of git to me.

I agree. I do not like it this way, but I am doing it until a better option is avaiable. What you propose here is such an option at the technical level. I cannot carry it over to other Git Forges, but it still is some progress.

For what it's worth, I intend to keep maintaining my repository if you don't like this approach. I will also probably write a nix flake to make things easier for me and other nix users.

I like what you are doing. Though I am not sure how to proceed, given that my main repo is on SourceHut. Maybe I can have a prominent link in the README to the builds you maintain? Ideas are most welcome!

calops commented 1 year ago

I don't know how practical that would be for you, but you could:

idnsunset commented 10 months ago

@calops , thanks for your release that fixes my issues in kitty. I've noticed that the 1.4 version has been released and it adds two new weights in which I think the medium weight would be useful to improve legibility in some cases, do you have any plan to update your own release?

calops commented 10 months ago

@idnsunset glad to know it helped somebody!

I had mostly made that fork as a proof of concept, and haven't pushed further since I moved away from kitty eventually. But yeah I could setup the CI to automatically build whenever upstream pushes a release, shouldn't be much work. Could you maybe open an issue (I just enabled them) for this on my fork so I don't forget?

protesilaos commented 4 days ago

Hello again! I do not know if this is still relevant, so I am closing it. I continue to build the fonts without Kitty support because it otherwise is too much for my hardware to build the fonts.