search

protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
524 stars 28 forks source link

Org deadline and scheduled faces don't distinguish clearly #102

Open alphapapa opened 3 months ago

alphapapa commented 3 months ago

Hi Prot,

I hope you're doing well. I've been working with my Org configuration, and I noticed that in modus-themes and ef-themes, the three Org Agenda deadline faces aren't clearly distinguished. They are:

In, e.g. modus-vivendi, all three of them are a bright red color, and the "imminent" face is also bold.

In the default Emacs theme, the "imminent" face is bright red and bold; the "upcoming" face is orange (actually, "Firebrick"); and the "distant" face inherits from org-default and has no other specified attributes. This way, in the Agenda, each relative deadline status is clearly distinguished. But with modus and ef, even distant deadlines look "angry", as if they are imminent or past due.

Maybe these faces aren't ones you use very much in your configuration (I'm not even sure if you really use Org Agenda much). But it would be great if these faces, in your excellent themes, could be fashioned after the defaults to preserve their distinct appearances.

Thanks as always for your work. My Emacs experience would not be the same without it!

alphapapa commented 3 months ago

Hi again Prot,

I just noticed that the same is true for the scheduled faces:

In the default theme, the first two faces are identical (although it seems to me that they should be at least slightly different), and the last one is orange (actually, "Firebrick", like `org-upcoming-deadline).

But in ef-themes, only org-scheduled has a defined foreground, and the other two faces merely inherit from it.

I notice that in modus-themes, org-scheduled-today is also bold; but org-scheduled-previously looks the same as org-scheduled.

Thanks for your consideration.

protesilaos commented 3 months ago

From: Adam Porter @.***> Date: Wed, 3 Apr 2024 19:08:45 -0700

Hi again Prot,

Hello Adam!

I just noticed that the same is true for the scheduled faces:

  • org-scheduled: Items scheduled for a certain day
  • org-scheduled-today: Items scheduled for today
  • org-scheduled-previously: Items scheduled previously, and not yet done

The reason I have not done much with them is because nobody asked and I was not sure what the best approach is. In my workflow, I do not differentiate between them because I remove the forewarnings and past dates from the today view.

On a more technical level, it is hard to communicate this nuance with colour alone. For scheduled dates we use a yellow hue. It is difficult to provide shades of yellow that are both legible and sufficiently distinct from each other when placed in the same context.

In the default theme, the first two faces are identical (although it seems to me that they should be at least slightly different), and the last one is orange (actually, "Firebrick", like `org-upcoming-deadline).

Perhaps the best way forward is to define semantic colour mappings in each theme palette and let the user set the colours they like?

Or do you think we should make strategic use of bold and italic (which note that it does not work---or work well---with all typefaces).

-- Protesilaos Stavrou https://protesilaos.com