search

protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
526 stars 29 forks source link

Error when running `org-html-htmlize-generate-css`. Invalid face: `modus-themes-variable-pitch` #106

Closed 8dcc closed 1 month ago

8dcc commented 1 month ago

When running M-x org-html-htmlize-generate-css, the function fails with the following error message:

face-attribute: Invalid face: modus-themes-variable-pitch

I tried looking inside modus-themes.el and I only saw it being used in a couple of places like:

https://github.com/protesilaos/modus-themes/blob/d2762db19ed48bd0cbba61c41940be479760a35e/modus-themes.el#L1771

But never actually defined. I tried replacing those occurrences with modus-themes-variable-pitch-ui, but basically the same error appears:

face-attribute: Invalid face: modus-themes-variable-pitch-ui

Not sure if this is an issue with the theme or with the org-html-htmlize-generate-css function.

8dcc commented 1 month ago

Updating the emacs-htmlize package to commit ed5e5b05fd260e8f161a488d56f10e7f6e01fb75 fixed it.

protesilaos commented 1 month ago

From: 8dcc  @.***> Date: Sun, 2 Jun 2024 08:02:22 -0700

Updating the emacs-htmlize package to commit ed5e5b05fd260e8f161a488d56f10e7f6e01fb75 fixed it.

I am curious what is happening here. You are right that modus-themes-variable-pitch is not defined. There has to be something wrong with modus-themes.el as well.

-- Protesilaos Stavrou https://protesilaos.com

8dcc commented 1 month ago

If you are curious, the old emacs-htmlize version was dd27bc3f26efd728f2b1f01f9e4ac4f61f2ffbf9. This is the full diff of the two commits, but it's pretty big.