Indistinct background color in swiper candidates

[wang1zhen]

The current selected candidate is somehow hard to distinguish in the swiper candidates due to the background color of org src blocks, it can be reproduced with following theme configurations:

(use-package modus-themes
      :init
      (setq modus-themes-bold-constructs t
            modus-themes-syntax '(alt-syntax green-strings yellow-comments)
            modus-themes-links '(neutral-underline background)
            modus-themes-hl-line '(intense)
            modus-themes-markup '(intense background)
            modus-themes-paren-match '(intense)
            modus-themes-org-blocks 'gray-background)
      :config
      (modus-themes-load-vivendi))

[protesilaos]

Hello @wang1zhen and thanks for reporting this!

I am trying it now. It has to be a bug with Swiper (or the intersection between Swiper and Org): it prioritises the underlying background. In the following screenshots, I changed the selected line in the minibuffer to a yellow background. But notice how we still get inconsistent results as I move between lines:

[wang1zhen]

I have also tried with vertico and consult, which can reproduce the same issue. AFAIK, vertico-current inherits modus-themes-completion-selected, and the background color of modus-themes-completion-selected seems to get overlapped by the org-block face, and I have no idea about how to fix it.

[protesilaos]

We can try asking Vertico's and Consult's maintainer (@minad). Perhaps adding a priority to the overlay would address this issue where the background of an Org block overrides the currently selected line in the minibuffer?

[minad]

In Vertico the problem should not be as serious since the vertico-current face extends to the full width of the minibuffer. We cannot give vertico-current higher priority, since this would interfere with modus-themes-completions with matches=background. Therefore the vertico-current face is appended to the other faces. I consider this issue as WONTFIX in Vertico/Consult. Either disable fontification in consult-line via consult-fontify-preserve=nil or disable the background for org blocks by modifying modus-themes-org-blocks.

[protesilaos]

Thanks for the explanation!