search

protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
526 stars 29 forks source link

modus themes and ediff #68

Closed bernardjoseph closed 1 year ago

bernardjoseph commented 1 year ago

Ediff does not use the right faces. Only when diff-mode is loaded, the faces are correct. The problem seems to be that the modus themes faces for ediff inherit faces from diff-mode. But diff-mode is not required by ediff. Without having diff-mode loaded, the faces seem not to be set correctly. If my observations are correct, the same problem can arise in other libraries too.

protesilaos commented 1 year ago

Thank you @bernardjoseph! I just pushed the change. Please let me know if it works for you.

bernardjoseph commented 1 year ago

I think the other inherited ediff faces must be fixed too.

Am 22.02.2023 um 10:39 schrieb Protesilaos Stavrou @.***>:

Thank you @bernardjoseph https://github.com/bernardjoseph! I just pushed the change. Please let me know if it works for you.

— Reply to this email directly, view it on GitHub https://github.com/protesilaos/modus-themes/issues/68#issuecomment-1439706279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEI5MCLWCHXYWEMX6ER33SDWYXNENANCNFSM6AAAAAAVEBOXCE. You are receiving this because you were mentioned.

bernardjoseph commented 1 year ago

The changes work for me.

Am 22.02.2023 um 10:39 schrieb Protesilaos Stavrou @.***>:

Thank you @bernardjoseph https://github.com/bernardjoseph! I just pushed the change. Please let me know if it works for you.

— Reply to this email directly, view it on GitHub https://github.com/protesilaos/modus-themes/issues/68#issuecomment-1439706279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEI5MCLWCHXYWEMX6ER33SDWYXNENANCNFSM6AAAAAAVEBOXCE. You are receiving this because you were mentioned.

protesilaos commented 1 year ago

Yes, all ediff faces need to avoid this inheritance. I updated it now.