search

protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
553 stars 30 forks source link

Palette-override support for background of the `prose-*` faces? #69

Closed okamsn closed 1 year ago

okamsn commented 1 year ago

The background setting for the old modus-themes-markup seems to have been left behind from the new palette overrides.

While it is easy to use the normal set-face-background, would you be open to adding palette-override support for backgrounds to the prose markup faces?

okamsn commented 1 year ago

After thinking it over, I'm not sure that the small benefit justifies the effort in changing this.

protesilaos commented 1 year ago

Hello @okamsn! In principle I am fine with this. The reason I removed them is that backgrounds are overriden by hl-line-mode. If we rely on them, we sometimes are not able to spot the special text. More so when visual-line-mode is in effect and the user works with long lines.