Support of new faces `vundo{-last}-saved`

[nsemrau]

Prot, after much switching I landed on the modus-themes for good. The amount of thought that went into them regarding contrast and accessibilty combined with breadth of the supported packages really make them a shining beacon in the world of Emacs themes. Thank you! :smile:

---

The already supported Vundo (visual undo) just released a new version. It now defines vundo-saved. This highlightes saved states in the undo chain.

Unfortunately, the highlight is a green color and looks hard to differentiate against unsaved states coloured in black in modus-operandi-tinted (my favourite theme):

The effect really is noticable when you have a longer chain and you see of the hihjlighted dots only in your peripheral vision. It is slighly better in modus-operandi.

In modus-vivendi-tinted, the dark background is helping. The dots are better to differentiate against the dark background:

vundo-last-saved also got defined. This sets an additional bold face on the green highlight. Maybe these faces would look more noticable/distinct in the chain, if you defined a colour from the standard modus colourspace for vundo-saved.

[protesilaos]

Hello @nsemrau! Yes, we can support this new face. I think a blue colour will stand out more.

Can you tell me what I need to do to save a state? Is it when the file is saved, or some specific arrangement the user has to make?

[nsemrau]

Oh, sorry, I should have been more clear about that. "Saving state" means the normal save-buffer in the chain of edits. A regular black/white dot, turns to green/vundo-saved when you hit save-buffer in order to represent the saved-to-disk status of this step in the chain.

[protesilaos]

Thank you! I just added support for them. I picked a cyan colour. Please let me know if that works for you. We can tweak it further if necessary.

[protesilaos]

I admit that I do not like the current style. It can be too subtle, depending on the fonts. The alternative is to use background colours. Though I am not sure about this either, as it does not look as pretty.

What do you think of these?

[nsemrau]

I strongly agree with »background colour not pretty« (in a general way, due to my dislike of background highlighting in interfaces, not because of your colour choices). Also, personally, I would try not to stray away from upstream's decisions towards the general look of their packages. So a better fitting colour without the background highlight would be my preferred way.

Semantically, it should communicate »Highlight, but friendly« (i. e. not in a optically warning way). Do you have a standard colour choice for that type of meaning?

[nsemrau]

I like the look of your last changes - the dots are very dishtinguishable between normal and saved state for me as an average-sighted person. The issue is solved from my point of view.

I will leave the ticket open for you, should you want to experiment a bit more regarding more contrast in the light themes. Maybe someone below average sightedness regarding contrast could have problems between regular (shadow) and saved (blue-intense) dots ...? (But that is just my gut feeling without any knowledge in this field.)

Thank you for yor quick extension and thank you again for your work on modus-themes!

[protesilaos]

I like the look of your last changes - the dots are very dishtinguishable between normal and saved state for me as an average-sighted person. The issue is solved from my point of view.

Thank you!

But that is just my gut feeling without any knowledge in this field.)

You are right. I am not entirely happy with it. I have been using it, but need to think of a different way to approach this. I experimented with using the main foreground for the saved states. The other nodes would be left to the lighter grey. It works. What I am not sure about is how a user goes about using this. Are they relying more on the tree or are they also checking the buffer to see how the contents are affected? Colour coding those states depends on their significance in the workflow, which is not clear to me.

[protesilaos]

This is done, by the way. I forgot to close the issue. Doing it now. Thank you!