protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
553 stars 30 forks source link

modus-themes-preset-overrides missing? #88

Closed domsch1988 closed 8 months ago

domsch1988 commented 1 year ago

According to the Instructions there should be 4 differen modus-themes-preset-overrides options to set. None of them seem to be available for me. Emacs 30.0.50 modus-themes 4.2.0

Config:

 (use-package modus-themes
    :custom
    (modus-themes-italic-constructs t)
    (modus-themes-bold-constructs nil)
    (modus-themes-mixed-fonts t)
    (modus-themes-variable-pitch-ui nil)
    (modus-themes-custom-auto-reload t)
    (modus-themes-disable-other-theme t)
    (modus-themes-to-toggle '(modus-operandi-tinted modus-vivendi-tinted))
    (modus-themes-org-blocks 'tinted-background)
    (modus-themes-common-palette-overrides modus-themes-preset-overrides-faint)
    (modus-themes-headings
     '((1 . (variable-pitch 1.5))
       (2 . (variable-pitch 1.3))
       (t . (variable-pitch 1.1))))
    :config
    (load-theme 'modus-operandi-tinted))

modus-themes-preset-overrides-faint is not defined in this case.

protesilaos commented 1 year ago

Hello @domsch1988! This is strange. The presets are defined in modus-themes.el. Could it be that :custom is evaluated before the variables are made avaiable? Try this and reload the theme for changes to take effect:

(setq modus-themes-common-palette-overrides modus-themes-preset-overrides-faint)
protesilaos commented 8 months ago

I assume this was an issue with an older version and has since been fixed.