search

protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
526 stars 29 forks source link

Support `corfu-candidate-overlay` package faces #89

Closed nsemrau closed 11 months ago

nsemrau commented 11 months ago

The completion popu package corfu gained the add-on package corfu-candidate-overlay. Instead of popping up a completion pop-up, it now previews the rest of the symbol as a completion candidate in a lighter face after the to-be-completed symbol (Picture).

It defines these faces:

(defface corfu-candidate-overlay-face
  '((((background light))
     :foreground "MistyRose4")
    (((background dark))
     :foreground "wheat"))
  "Face used for the overlay with the first candidate.")

(defface corfu-candidate-overlay-face-exact-match
  '((t (:inherit 'corfu-candidate-overlay-face :underline t)))
  "Face used for the overlay when there is only one candidate.")

While the faint yellowish wheat tone in modus-vivendi-tinted is quite acceptable for me in the readability department as a average-sighted person, official support for this neat package with a color from the Modus pallete would be great.

protesilaos commented 11 months ago

Hello @nsemrau! I just added support for the relevant face. I made it inherit from shadow, so it will appear gray. Please let me know if this works for you.

nsemrau commented 11 months ago

I tested the change against light and dark Modus themes. I find it quite homourous that the "shadow" of a possible completion is expressed by the face attribute "shadow". :D

The version against is super legible. While losing a hint of brightness when going from wheat to shadow, I think it expresses the raison d’être of this package even better now. Thank you for your quick and improving change!

protesilaos commented 11 months ago

You are welcome!