search

protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
553 stars 30 forks source link

should probably unify the colors of `imenu-list-entry-subalist-face` and `menu-list-entry-face` #95

Closed ltmsyvag closed 9 months ago

ltmsyvag commented 9 months ago

Modus lover here!

The imenu-list face settings in modus-themes.el, namely: https://github.com/protesilaos/modus-themes/blob/5a777c30ca9f915e97ffd394736a4d547a8899e4/modus-themes.el#L2647-L2654 set 8 different colors for 8 different imenu-list faces, but this is causing visual confusion. Because in fact, an imenu-list entry imenu-list-entry-subalist-face-<num> is at the same level as imenu-list-entry-face-<num> (they have the same <num>!), the only difference is that the former contains sub-entires.

The modus-vivendi colorization of imenu-list now looks like: Screenshot 2024-01-04 at 18 05 53 which is confusing, because "Earth" is at the same level as Venus, but it has a different color. What's NOT confusing would look like below: Screenshot 2024-01-04 at 18 03 21

Without modus-themes, the above is also the default behavior of imenu-list, which I produce below with a vanilla-ish emacs: Screenshot 2024-01-04 at 18 28 39

protesilaos commented 9 months ago

Thank you @ltmsyvag! You are right. I don't remember why it was with eight colours before. Just made the change.