protesilaos / modus-themes

Highly accessible themes for GNU Emacs, conforming with the highest standard for colour contrast between background and foreground values (WCAG AAA).
https://protesilaos.com/emacs/modus-themes
GNU General Public License v3.0
526 stars 29 forks source link

Add support for `xterm-color` and (parts of) `rustic-mode` #99

Closed slotThe closed 4 months ago

slotThe commented 4 months ago

Hi Prot,

this is a tiny PR that adds support for xterm-color.el—which is a library that works much like ansi-color.el—as well as the compilation part of rustic-mode (because they inconveniently overwrite the respective xterm-color settings with their own). These changes are essentially analogous to what's already been done for ansi-color-names-vector.

Without this override, the compilation buffer may sometimes look like this:

2024-02-25-084128_301x53_scrot

I'm sure you'll agree that this is quite unreadable :)

Commit Summary

Add support for rustic-ansi-faces

Most of rustic-modes faces are deprecated in favour of this unifying approach, hence only this one face is added. Unlike the name suggests, this does not use ansi-color.el, but rather xterm-color.el; this has no effect in terms of the color specification, though.

Add xterm-color support

This is a GNU ELPA package that essentially does what ansi-color.el also does. The reason for supporting it is that other third-party packages may depend on xterm-color, and if we just leave it to its own devices it may produce nearly unreadable output.

protesilaos commented 4 months ago

Merged. Thank you!