Closed metalelf0 closed 7 years ago
This is awesome work! Many thanks!
It also comes at a time when I was reviewing the entire repository (and added the Terminator ports/configs).
All looks good to me. I just had a minor note where I requested a change.
Also, as you can see from the terminator
dir under each item, I am including a README (example) with a proviso:
This is experimental. Not all use cases have been checked. Colour mapping may require further refinements. Also note that I have only tested this on my Arch Linux and Linux Mint machines.
I can write something similar for all your contributions. What do you think?
@protesilaos very good! I updated the path as you suggested. :+1: for the proviso README
; I tested some of the schemes with iTerm2 3.0 daily builds under macOS Sierra 10.12.2 and they look consistent.
Excellent! Much appreciated.
Will add the iterm2 README
shortly.
Also, I will update the "thanks to" section to provide full attribution to your work. Same with my website's scheme pages. I will add a section about iterm2, plus reference to your work.
I had some spare time this weekend so I put together a small ruby script to convert all the color palettes from prot16 to iterm2 colorschemes.
I generated both light and dark variants; you can see how I mapped prot16 labels to iterm2 values under
LIGHT_PROFILE_MAPPINGS
andDARK_PROFILE_MAPPINGS
inutils/prot16_to_iterm2.rb
. The color conversion is done in theColor
class.I have tested only a couple of them and they look good, if anything looks odd let me know and I'll do my best to fix it :)